SMQ-2546 - Add events to adapters #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
smq2546-events
branch
from
7778d73 to
b39d060
Compare
dborovcanin
force-pushed
the
smq2546-events
branch
from
b39d060 to
a9c77e9
Compare
felixgateru
force-pushed
the
smq2546-events
branch
2 times, most recently
from
f5d7ba7 to
badab49
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
==========================================
- Coverage 43.87% 38.97% -4.90%
==========================================
Files 350 59 -291
Lines 45718 2876 -42842
==========================================
- Hits 20059 1121 -18938
+ Misses 23438 1655 -21783
+ Partials 2221 100 -2121 ☔ View full report in Codecov by Sentry. |
dborovcanin
force-pushed
the
smq2546-events
branch
from
0d1f132 to
5fd66b6
Compare
dborovcanin
requested changes
Jan 24, 2025
ws/handler.go
Outdated
Comment on lines
263
to
268
| switch { | ||
| case strings.HasPrefix(string(s.Password), "Client"): | ||
| token = strings.ReplaceAll(string(s.Password), "Client ", "") | ||
| default: | ||
| token = string(s.Password) | ||
| } |
There was a problem hiding this comment.
Use extractClientSecret instead.
felixgateru
force-pushed
the
smq2546-events
branch
2 times, most recently
from
cf13ed3 to
6bad00d
Compare
dborovcanin
force-pushed
the
smq2546-events
branch
from
6bad00d to
3c2214e
Compare
dborovcanin
requested changes
Jan 27, 2025
ws/events/stream.go
Outdated
|
|
||
| //go:generate mockery --name EventStore --output=../mocks --filename events.go --quiet --note "Copyright (c) Abstract Machines" | ||
| type EventStore interface { | ||
| Publish(ctx context.Context, clientID, channelID, topic string) error |
There was a problem hiding this comment.
Use subtopic here, just like in other methods.
http/handler.go
Outdated
Comment on lines
199
to
201
| if err := h.es.Publish(ctx, clientID, msg.Channel, msg.Subtopic); err != nil { | ||
| return errors.Wrap(errFailedPublishEvent, err) | ||
| } |
There was a problem hiding this comment.
Event store should be wrapper around interfaces. I.e. it should be transparent from the adapter implementation because we are using middlewares. Use same approach we have for all the other services.
felixgateru
force-pushed
the
smq2546-events
branch
2 times, most recently
from
c61af1a to
dd09cd2
Compare
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
dborovcanin
force-pushed
the
smq2546-events
branch
from
dd09cd2 to
34f71fa
Compare
dborovcanin
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature as it adds events to
coapandwsand updates events inmqtt.What does this do?
This pr adds
publish,susbscribeandunsubscribeevents to the adapters.Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
Yes, in code docuementation is included
Notes
None